Downgrade and do not automatically update Go deps #1979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
force-pushed
the
downgrade-fsnotify
branch
from
f9c3f60 to
9d164b7
Compare
fmeum
changed the title
With Bzlmod now being the primary way Gazelle is used, we should no longer update the Go dependencies with each release as this just reduces the amount of flexibility afforded to dependent projects. Thanks to MVS, they can easily force newer versions.
fmeum
force-pushed
the
downgrade-fsnotify
branch
from
9d164b7 to
5a5cac1
Compare
linzhp
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What package or component does this PR mostly affect?
go_depsWhat does this PR do? Why is it needed?
With Bzlmod now being the primary way Gazelle is used, we should no longer update the Go dependencies with each release as this just reduces the amount of flexibility afforded to dependent projects. Thanks to MVS, they can easily force newer versions.
Also test with Bazel 8.0.0rc2 in BCR presubmit.
Which issues(s) does this PR fix?
Work towards #1977
Other notes for review