Evaluate build tags as both true and false #1938
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Gazelle already iterates over all supported os/arch combos to include go files. This is similar but expanded to custom tags. When adding a new build tag, we create a copy with the tag set to true and append to the original. This means that build tag evaluation will grow exponentially.
patrickmscott
force-pushed
the
patrick/conditional-tags
branch
from
8162813 to
1b7c214
Compare
fmeum
reviewed
Oct 25, 2024
language/go/config.go
Outdated
| type tagSet map[string]bool | ||
|
|
||
| func (ts tagSet) clone() tagSet { | ||
| c := make(tagSet) |
There was a problem hiding this comment.
Suggested change
| c := make(tagSet) | |
| c := make(tagSet, len(ts)) |
language/go/config.go
Outdated
| @@ -41,6 +41,16 @@ import ( | |||
|
|
|||
| var minimumRulesGoVersion = version.Version{0, 29, 0} | |||
|
|
|||
| type tagSet map[string]bool | |||
There was a problem hiding this comment.
Are we actually using the "present, but mapped to false" state or should this be a map[string]struct{}?
Specify the map size hint. Refactor the map to use struct instead of bool.
fmeum
approved these changes
Oct 30, 2024
There was a problem hiding this comment.
@tyler-french Could you test this at Uber? I would like to make sure that we don't see any accidental exponential blowup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gazelle already iterates over all supported os/arch combos to include go files. This is similar but expanded to custom tags. When adding a new build tag, we create a copy with the tag set to true and append to the original. This means that build tag evaluation will grow exponentially.
Fixes #1262
What type of PR is this?
Feature
What package or component does this PR mostly affect?
language/go
What does this PR do? Why is it needed?
It changes the behavior of
build_tagsto defer evaluation to build time. Instead of assuming the tag is always true, it treats the tag as both true and false when evaluating tags for a file.Which issues(s) does this PR fix?
Fixes #1262
Other notes for review