fix(GPHedge): replace list with sequence #524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
till-m
added a commit
to till-m/BayesianOptimization
that referenced
this pull request
Oct 9, 2024
* fix: import error from exception module (bayesian-optimization#525) * fix: replace list with sequence (bayesian-optimization#524) * Fix min window type check (bayesian-optimization#523) * fix: replace dict with Mapping * fix: replace list with Sequence * fix: add type hint * fix: does not accept None * Change docs badge (bayesian-optimization#527) * fix: parameter, target_space * fix: constraint, bayesian_optimization * fix: ParamsType --------- Co-authored-by: till-m <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given the use case below, it seems that
base_acquisitionsinGPHedgecan have multiple types ofAcquisitionFunction.BayesianOptimization/tests/test_acquisition.py
Line 276 in 10ef3be
However, the type args in
listare fixed, so they do not allow such a situation.Therefore, we need to change to
Sequence, which allows args withcovariant=True.I was going to ignore it because it's related to generics,
but it seemed necessary for the use case you're considering, so I fixed it.
Note
This is not a complete description.
But I think it will help you understand why the error is occurring.
list[T: AcquisitionFunction]: All elements inlistareT.Sequence[T_co: AcquisitionFunction]: Every element inSequenceis eitherT_coor a subclass ofT_co.