Skip to content

Commit

Permalink
Added su-exec to ARM dockerfiles and removed USER line
Browse files Browse the repository at this point in the history
  • Loading branch information
AgileVirus committed Jul 9, 2020
1 parent 4bfcc5b commit fd9237e
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 9 deletions.
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ RUN addgroup -S ${GROUP} -g ${GID} && adduser -D -S -u ${UID} ${USER} ${GROUP} &

COPY --from=build-stage --chown=${USER}:${GROUP} /app/dist /www/
COPY --from=build-stage --chown=${USER}:${GROUP} /app/dist/assets /www/default-assets
COPY --chown=${USER}:${GROUP} entrypoint.sh /entrypoint.sh
COPY entrypoint.sh /entrypoint.sh

EXPOSE ${PORT}
VOLUME /www/assets
Expand Down
5 changes: 2 additions & 3 deletions Dockerfile.arm32v7
Original file line number Diff line number Diff line change
Expand Up @@ -28,14 +28,13 @@ ENV UID 911
ENV PORT 8080

RUN addgroup -S ${GROUP} -g ${GID} && adduser -D -S -u ${UID} ${USER} ${GROUP} && \
apk add -U darkhttpd && \
apk add -U darkhttpd su-exec && \
rm /usr/bin/qemu-arm-static

COPY --from=build-stage --chown=${USER}:${GROUP} /app/dist /www/
COPY --from=build-stage --chown=${USER}:${GROUP} /app/dist/assets /www/default-assets
COPY --chown=${USER}:${GROUP} entrypoint.sh /entrypoint.sh
COPY entrypoint.sh /entrypoint.sh

USER ${USER}
EXPOSE ${PORT}
VOLUME /www/assets
ENTRYPOINT ["/bin/sh", "/entrypoint.sh"]
5 changes: 2 additions & 3 deletions Dockerfile.arm64v8
Original file line number Diff line number Diff line change
Expand Up @@ -28,14 +28,13 @@ ENV UID 911
ENV PORT 8080

RUN addgroup -S ${GROUP} -g ${GID} && adduser -D -S -u ${UID} ${USER} ${GROUP} && \
apk add -U darkhttpd && \
apk add -U darkhttpd su-exec && \
rm /usr/bin/qemu-aarch64-static

COPY --from=build-stage --chown=${USER}:${GROUP} /app/dist /www/
COPY --from=build-stage --chown=${USER}:${GROUP} /app/dist/assets /www/default-assets
COPY --chown=${USER}:${GROUP} entrypoint.sh /entrypoint.sh
COPY entrypoint.sh /entrypoint.sh

USER ${USER}
EXPOSE ${PORT}
VOLUME /www/assets
ENTRYPOINT ["/bin/sh", "/entrypoint.sh"]
4 changes: 2 additions & 2 deletions entrypoint.sh
Original file line number Diff line number Diff line change
Expand Up @@ -11,5 +11,5 @@ fi
# Install default config if no one is available.
yes n | cp -i /www/default-assets/config.yml.dist /www/assets/config.yml &> /dev/null

chown -R $UID:$GID /www/assets/*
exec su-exec $USER:$GROUP darkhttpd /www/ --no-listing --port "$PORT"
chown -R $UID:$GID /www/assets
exec su-exec $UID:$GID darkhttpd /www/ --no-listing --port "$PORT"

0 comments on commit fd9237e

Please sign in to comment.