-
Notifications
You must be signed in to change notification settings - Fork 23
Add support for parsing config file for basti init #123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Hi @Sharu95, thank you for your interest in contributing to Basti! I'll try to look at the changes this weekend. Meanwhile, could you please explain the motivation for the changes and the example of the new config? |
|
Hi @BohdanPetryshyn, happy to contribute! Still just a draft PR but I wanted to put it out there so its easier to iterate on it with feedback. Currently not perfectly parsing from config, but the setup works. Tags are passed from CLI options as well. My main motivation was to be able to run If the target is part of the connection setup, it should still be parsed as a connection target, but this setup is more or less to adhere to the init command as well, with the config file 🙌🏾 Another motivation I've had is that we manage some of our RDS resources in terraform. The security group used by basti/bastion instance is often deleted during terraform deployments/applies, because its not tracked in terraform, so we end up running basti init more often than ideal if we use terraform a lot |
|
Hello @Sharu95! I didn’t include initialization from config because ideally, In the scenario you described, you can stop Terraform from deleting the security group created by Basti by specifically listing it in the Terraform configuration: vpc_security_group_ids = [<your-existing-security-groups>, <basti-created-security-group-id>]However, I believe that config-driven automatic Basti initialization could be beneficial in other situations, so your contribution remains valuable! |
|
Hey again @BohdanPetryshyn! That is probably one way to solve it, but I was under the impression that Basti creates new security groups, so this changes I can continue iterating on it if you have plans making a release of this anytime soon. If not, I have some other prioritizations I'd have to work with before I can come back to this 🙌🏾 |
|
The That said, I'm open to collaborating and releasing the feature at your pace! |
|
@BohdanPetryshyn, ok nice, I will test the terraform solution as well and see how it works! 🙌🏾 Then I'll work a bit on this PR on the side to make the contribution 👍🏾 Thanks for input! |
|
@Sharu95 Looking forward to your contribution! 🚀 |
Proposed Changes
This PR adds support for parsing the config file for the basti init command.
Related Issues/PRs
Checklist
npm run test).