Merge pull request #38 from Dargun/issue-37

README.md

@@ -19,6 +19,9 @@ Boost::ASIO low-level redis client (connector)
 
 ## Changelog
 
+### 0.09
+- [bugfix] critical bug in protcol serialization on empty values
+
 ### 0.08
 - relaxed c++ compiler requirements: c++11 can be used instead of c++14
 
@@ -764,6 +767,7 @@ MIT
 - [Vinnie Falco](https://github.com/vinniefalco)
 - [Stephen Coleman](https://github.com/omegacoleman)
 - [maxtorm miximtor](https://github.com/miximtor)
+- [Ronny Nowak](https://github.com/dargun)
 
 ## See also
 - https://github.com/Cylix/cpp_redis

include/bredis/impl/protocol.ipp

@@ -442,7 +442,7 @@ inline std::size_t size_for_int(std::size_t arg) {
         ++r;
         arg /= 10;
     }
-    return r;
+    return std::max<size_t>(1, r); /* if r == 0 we clamp max to 1 to allow minimum containing "0" as char */
 }
 
 inline std::size_t command_size(const single_command_t &cmd) {
@@ -477,9 +477,11 @@ inline void Protocol::serialize(DynamicBuffer &buff,
         it += bytes;
         total += bytes;
 
-        buffer_copy(it, buffer(arg.data(), arg.size()));
-        it += arg.size();
-        total += arg.size();
+        if(!arg.empty()) {
+            buffer_copy(it, buffer(arg.data(), arg.size()));
+            it += arg.size();
+            total += arg.size();
+        }
 
         buffer_copy(it, buffer("\r\n", terminator.size));
         total += terminator.size;