Improve error detection in omarchy-update-analyze-logs#4488
Open
paul-fornage wants to merge 1 commit intobasecamp:devfrom
Open
Improve error detection in omarchy-update-analyze-logs#4488paul-fornage wants to merge 1 commit intobasecamp:devfrom
omarchy-update-analyze-logs#4488paul-fornage wants to merge 1 commit intobasecamp:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was getting really unhelpful error messages after omarchy update that always took like 45 seconds to find and figure out. Not the end of the world but with 100k users (guess) this is like cumulative days for a problem I can fix in an hour.
The problem
Before:
I manually added some test cases to the update logs, but the gcc
-Werror=...is real and I get like 8 of those. With line wrapping thats like half a screen of arbitrary args to sort for why the error shows up.The solution?
Now, there is an 'exclude list' for times the string 'error' appears, but is obviously not part of an error. These are ignored.
Also, when the real errors are printed, the capture that triggered the line to be included the 'error' is in red, so this cues the user that we are just doing a string search and it might not be an error, as well as letting them easily scan that essay to find out it's not real.