Add patch to /etc/updatedb.conf to include /home directory#4292
Open
jorge-campo wants to merge 1 commit intobasecamp:masterfrom
Open
Add patch to /etc/updatedb.conf to include /home directory#4292jorge-campo wants to merge 1 commit intobasecamp:masterfrom
jorge-campo wants to merge 1 commit intobasecamp:masterfrom
Conversation
dhh
reviewed
Jan 31, 2026
| fi | ||
| else | ||
| echo "Warning: $UPDATEDB_CONF not found; skipping PRUNE_BIND_MOUNTS configuration" >&2 | ||
| fi |
Member
There was a problem hiding this comment.
We don't need any of this defensive guarding since this is all running against a known, fixed target on install. So you can just execute the grep/sed pair directly.
Member
|
Good catch. We also need a migration for existing installations 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem description
New Omarchy Linux installations currently ship with the following value in in
/etc/updatedb.conf:PRUNE_BIND_MOUNTS = "yes"With this value, the
updatedbrun used bylocate/plocateprunes bind mounts, which results in paths under/homebeing omitted from the locate database. As a consequence, searches vialocate/plocatedo not return matches for files located in users’ home directories.This PR updates the default configuration to:
PRUNE_BIND_MOUNTS = "no"so that /home contents are indexed and searchable by default after installation.
Steps to reproduce the issue
grep -n 'PRUNE_BIND_MOUNTS' /etc/updatedb.conf. Expected to show:PRUNE_BIND_MOUNTS = "yes"./home:touch /home/$USER/locate-test-file.locate/plocatedatabase:sudo updatedb.locate locate-test-file(orplocate locate-test-file). Notice the file is missing from results.Summary of changes
During installation, before running
updatedbininstall/config/localdb.sh, the script now enforcesPRUNE_BIND_MOUNTS = "no"in/etc/updatedb.conf(whitespace-tolerant: updates the existing setting if present, otherwise appends it), then rebuilds the locate database as usual.Testing
Verified the updated
localdb.shscript on an existing Omarchy 3.3.3 installation: the script executed successfully with no errors andupdatedbcompleted as expected.Built and installed a new Omarchy ISO from the
omarchy-isorepository using:Installation completed without issues using this ISO image, and after the install,
/etc/updatedb.confcontained the updatedPRUNE_BIND_MOUNTS = "no"value.Screenshot from the installation test on a virtual machine:
Note
This PR was prepared with support from GitHub Copilot.
closes #3744