-
Notifications
You must be signed in to change notification settings - Fork 486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add proxy boot_config --publish-ip argument #1265
base: main
Are you sure you want to change the base?
Conversation
This looks great 👏🏻 will try it out asap, thanks! |
@djmb how would you feel about me allowing support for multiple IP addresses to be specified? Would use Thor's I was just thinking about the folks that may want to bind to a specific interface that supports both IPv4 and IPv6. Example:
|
@djmb hey mate, I have just added support for multiple IP addresses. There was a bit of a gotcha with using option
So instead, I went ahead and implemented the logic inside I'm of course open to feedback / alternative solutions on this. In addition I added a simple IPv4/v6 validator for the argument value (not sure if we want to support this or not). |
Implements basecamp/kamal-proxy#74
Allows for
kamal proxy boot_config set --publish-ip=x.x.x.x
Context:
By default Docker will bind to all available interfaces.