billing.rb: destroy -> destroy! #2508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

henrik wants to merge 1 commit into basecamp:main from henrik:patch-1

+1 −1

henrik commented Feb 8, 2026

Don't have much context but from a quick look, there's no intentional "silently fail to destroy" path here.


          billing.rb: destroy -> destroy!

f50b0bc

Author

henrik commented Feb 8, 2026 •

edited

Loading

There are a bunch more destroy where the return value is ignored. I'm guessing most should ideally be destroy!.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet