feat: i18n support #2489
feat: i18n support #2489
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f9e207502b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| card_deleted: "Card deleted" | ||
| card_added: "Card added" | ||
| display: |
There was a problem hiding this comment.
config/locales/en/cards.yml is syntactically invalid because card_deleted/card_added are outdented and display is over-indented, so YAML parsing fails (expected <block end> around line 12). Rails loads locale files at boot, so this breaks i18n loading and can prevent the app/test environment from starting.
Useful? React with 👍 / 👎.
| I18n.t("events.descriptions.card_published", creator: creator, card_title: card_title) | ||
| when "card_closed" | ||
| %(#{creator} moved #{card_title} to "Done") | ||
| I18n.t("events.descriptions.card_closed", creator: creator, card_title: card_title, column: I18n.t("columns.done")) |
There was a problem hiding this comment.
This now calls I18n.t("events.descriptions.*") (and related events.creator_* keys), but config/locales/en/events.yml only defines events.empty_days. In runtime these descriptions render as translation missing, and in test env (with raise_on_missing_translations = true) any covered path will raise, so event timeline text generation regresses.
Useful? React with 👍 / 👎.
| I18n.t("events.descriptions.card_published", creator: creator, card_title: card_title) | ||
| when "card_closed" | ||
| %(#{creator} moved #{card_title} to "Done") | ||
| I18n.t("events.descriptions.card_closed", creator: creator, card_title: card_title, column: I18n.t("columns.done")) |
There was a problem hiding this comment.
The code now translates columns.done/columns.not_now/columns.maybe, but config/locales/en/columns.yml only contains choose, add_card, no_cards_here, maximize_column, and expand_column. As a result, core board/card labels and event text show missing-translation strings (or raise in strict i18n contexts).
Useful? React with 👍 / 👎.
1 participant
Uh oh!
There was an error while loading. Please reload this page.