Open
Conversation
Collaborator
🟡 Heimdall Review Status
|
nqd
force-pushed
the
page-manager-with-buffer-pool
branch
3 times, most recently
from
dc1f170 to
b35459b
Compare
nqd
commented
Sep 18, 2025
| } | ||
|
|
||
| /// Retrieves a page from the memory mapped file. | ||
| pub fn get(&self, _snapshot_id: SnapshotId, page_id: PageId) -> Result<Page<'_>, PageError> { |
Collaborator
Author
There was a problem hiding this comment.
remove unused snapshot_id
nqd
changed the title
nqd
commented
Sep 18, 2025
src/page/manager/cache_evict.rs
Outdated
|
|
||
| // TODO: Temporarily use LruReplacer as the eviction policy, replace with a better eviction policy | ||
| pub(crate) struct CacheEvict { | ||
| lru_replacer: LruReplacer<PageId>, |
Collaborator
Author
There was a problem hiding this comment.
A new cache eviction policy will be in the nextPR
nqd
commented
Sep 18, 2025
| .map_err(|_| PageError::InvalidValue)?; | ||
| // Use O_DIRECT on Linux for better performance, but not available on macOS | ||
| #[cfg(target_os = "linux")] | ||
| let flags = libc::O_RDWR | libc::O_CREAT | libc::O_DIRECT; |
Collaborator
Author
There was a problem hiding this comment.
O_DIRECT to bypass OS page cache, hence avoid double caching
nqd
force-pushed
the
page-manager-with-buffer-pool
branch
from
266f484 to
c820e65
Compare
This reverts commit 785b631.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TBA