Conversation
Collaborator
✅ Heimdall Review Status
|
danyalprout
previously requested changes
Apr 24, 2025
Collaborator
There was a problem hiding this comment.
Instead of duplicating the existing Reth setup can we parameterize the binary in the existing image? (or use a shared base image).
Parameterizing the binary (with the default being the current version) feels like the way to go IMO. It'll make the images bigger due to having a second binary, but that's a temporary state -- we'll want to make our Reth build the default one.
Approved review 2791311177 from danyalprout is now dismissed due to new commit. Re-request for approval.
danyalprout
approved these changes
Apr 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding instruction to https://github.com/base/node-reth under the reth folder, also a README for more info.