Merged
Conversation
Collaborator
✅ Heimdall Review Status
|
0x00101010
approved these changes
Mar 19, 2025
Contributor
|
Thank you for this, would you be able to try fix nethermind build issue and also dedup the code as well? @dguenther |
Contributor
Author
|
Yep! I'll make tracking issues for those and work on them in separate PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the action workflows to build images for amd64 and arm64, then create a multiplatform manifest image for them.
Changes
The builds were using QEMU, but that seemed to OOM or take 5+ hours to complete. This PR uses the Linux ARM runners that are available in public preview. The multiplatform build is based off the Docker docs.
Future Improvements
Builds still take between ~26-40 mins to complete, up from ~20 mins with x64. If that's too slow, we could try larger ARM runners or optimizing the reth build.
There's a lot of code duplication in the workflows -- it'd be nice to clean up, but I think it'd make this PR tough to review if it was done here.
Testing
ghcr.io/dguenther/node-geth:main, etc. Tested and merged this on my fork (with the repo owner changed).node,node-geth,node-rethon Base Sepolia for ~30 secs using supervisordnode-netherminderrors withspawnerr: command at '/app/execution-entrypoint' is not executableunder supervisord -- I reproduced that issue onbase/node-nethermind:main, so not related to this change. lmk if you'd like additional testing here.