-
Notifications
You must be signed in to change notification settings - Fork 489
docs (flashblocks): add overview page and improve structure #869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
🟡 Heimdall Review Status
|
Co-authored-by: cody-wang-cb <cody.wang@coinbase.com>
Co-authored-by: cody-wang-cb <cody.wang@coinbase.com>
| | 10 | Full block limit (~187.5M gas) | | ||
|
|
||
| **Implications for large transactions:** | ||
| - Transactions with gas limits > 1/10 of block limit (currently ~18.75M gas) will never fit in a Flashblock |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is incorrect unless something has changed.
If a transaction consumes 20Mgas, it can be included as early as the 2nd flashblock (so long as the first flashblock has at least 1.25M gas unconsumed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a max gas limit per transaction. now, but this is different than the size of an individual flashblock
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How could we use mintlify components to improve the organization of this page? Would drop downs or toggles be better so that people can view only the answers they want to?
Approved review 3712473321 from ericbrown99 is now dismissed due to new commit. Re-request for approval.
What changed? Why?
Improves Flashblocks documentation based on the Deep Dive blog post, which was proving more helpful for teams than the existing docs.
Updates:
Notes to reviewers
How has it been tested?
Locally