Skip to content

refactor: implement structured error codes for signer and payment fai…#237

Open
0xkuzeydurden wants to merge 1 commit intobase:masterfrom
0xkuzeydurden:patch-2
Open

refactor: implement structured error codes for signer and payment fai…#237
0xkuzeydurden wants to merge 1 commit intobase:masterfrom
0xkuzeydurden:patch-2

Conversation

@0xkuzeydurden
Copy link

…lures

  • Updated BaseAccountProvider.ts and getPaymentStatus.ts to handle asynchronous errors more effectively.
  • Introduced explicit checks for EIP-1193 error code 4001 to return a structured 'user_rejected' code.
  • Added 'rate_limit_exceeded' detection for bundler/RPC responses in payment status checks.
  • Provides developers with programmatically accessible error codes for better UI/UX handling.

Summary

How did you test your changes?

…lures

- Updated BaseAccountProvider.ts and getPaymentStatus.ts to handle asynchronous errors more effectively.
- Introduced explicit checks for EIP-1193 error code 4001 to return a structured 'user_rejected' code.
- Added 'rate_limit_exceeded' detection for bundler/RPC responses in payment status checks.
- Provides developers with programmatically accessible error codes for better UI/UX handling.
@cb-heimdall
Copy link
Collaborator

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants