refactor: implement structured error codes for signer rejections#236
Open
0xkuzeydurden wants to merge 1 commit intobase:masterfrom
Open
refactor: implement structured error codes for signer rejections#2360xkuzeydurden wants to merge 1 commit intobase:masterfrom
0xkuzeydurden wants to merge 1 commit intobase:masterfrom
Conversation
This PR introduces structured error handling in BaseAccountProvider to address unclear feedback during signer failures. By intercepting EIP-1193 code 4001, the SDK now returns a programmatically accessible user_rejected code, enabling better UI/UX handling for developers. Closes base#213
Collaborator
🟡 Heimdall Review Status
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces structured error handling in BaseAccountProvider to address unclear feedback during signer failures. By intercepting EIP-1193 code 4001, the SDK now returns a programmatically accessible user_rejected code, enabling better UI/UX handling for developers.
Closes #213
Summary
How did you test your changes?