Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor documentation improvements: typo fix and slug update #1412

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

prestoalvarez
Copy link
Contributor

What changed?
File 1: decommissioning-public-geth-archive-snapshots.md
Slug was updated:
Old: /decommissioning-public-geth-archive-snapshots
New: /decommissioning-public-geth-archive-snapshots
Reason: The slug path had unnecessary issues (though visually no change is visible, perhaps fixing unseen formatting or whitespace issues).

File 2: basenames-onchaintkit-tutorial.md
Fix in description text:
Old: "teaches how to intergrate Basenames"
New: "teaches how to integrate Basenames"
Reason: Corrected a typo in the word intergrate to integrate for better clarity and accuracy.

Why?

  • To fix a typo (intergrateintegrate) in the Basenames tutorial.
  • To clean up or standardize the slug in the decommissioning-public-geth-archive-snapshots.md file.

Notes to reviewers

  • Review the changes to confirm the typo fix and check that the slug behaves correctly after the update.
  • Ensure there are no unintended modifications.

How has it been tested?

  • The changes are minor textual updates. Likely tested locally or visually verified in the rendered markdown.
  • No functional code changes were made, so minimal testing was necessary.

Copy link

vercel bot commented Dec 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-base-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 17, 2024 6:46pm

Copy link

vercel bot commented Dec 17, 2024

@prestoalvarez is attempting to deploy a commit to the Coinbase Team on Vercel.

A member of the Team first needs to authorize it.

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Dec 17, 2024

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

Copy link
Member

@wbnns wbnns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@prestoalvarez Thanks!

@wbnns wbnns enabled auto-merge (squash) December 18, 2024 12:51
@wbnns wbnns merged commit 12cf626 into base-org:master Dec 18, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants