Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): Pr docker build ci #117

Merged
merged 3 commits into from
Oct 4, 2023
Merged

Conversation

Mitsuwa
Copy link
Contributor

@Mitsuwa Mitsuwa commented Oct 4, 2023

What

This adds a github action workflow, similar to the on_merge docker.yml file that runs on pull_request that will build the Dockerfile at the root of the gitrepo in order to verify building the dockerfile still works, so that there are not merges that break the docker build. The build will not push, as there is no login attempt step or creds specified

Testing

You should see the job complete in the github actions

@Mitsuwa Mitsuwa changed the title Pr docker build ci feat(ci): Pr docker build ci Oct 4, 2023
Copy link
Contributor

@mdehoog mdehoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea, thank you

@mdehoog mdehoog merged commit fe172bd into base-org:main Oct 4, 2023
1 check passed
@wbnns wbnns added the type: enhancement New feature or request label Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants