fix bug with *struct

bardia-key · Aug 9, 2020 · 78a2ad3 · 78a2ad3
1 parent 564a4cf
commit 78a2ad3
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/config.go b/config.go
@@ -111,6 +111,11 @@ func configFilePath(app string) (string, error) {
 
 func configFileType(config interface{}) (string, error) {
 	t := reflect.TypeOf(config)
+	if t.Kind() == reflect.Ptr {
+		// Extract the underlying object
+		t = t.Elem()
+	}
+
 	if t.Kind() != reflect.Struct {
 		return "", errors.New("config must be a struct")
 	}

diff --git a/config_test.go b/config_test.go
@@ -53,6 +53,15 @@ func TestConfigFileType(t *testing.T) {
 		assert.Equal(t, cftXML, cft)
 	})
 
+	t.Run("detects *struct", func(t *testing.T) {
+		type J struct {
+			A string `json:"a"`
+		}
+		cft, err := configFileType(&J{})
+		require.NoError(t, err)
+		assert.Equal(t, cftJSON, cft)
+	})
+
 	t.Run("errors on non-struct ", func(t *testing.T) {
 		_, err := configFileType("qeubar")
 		assert.Error(t, err)