-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce new LS API to get the design model for a ballerina package #519
Merged
LakshanWeerasinghe
merged 17 commits into
ballerina-platform:main
from
LakshanWeerasinghe:design-ls-api
Dec 18, 2024
Merged
Introduce new LS API to get the design model for a ballerina package #519
LakshanWeerasinghe
merged 17 commits into
ballerina-platform:main
from
LakshanWeerasinghe:design-ls-api
Dec 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LakshanWeerasinghe
force-pushed
the
design-ls-api
branch
from
December 11, 2024 08:14
1207796
to
073b1c2
Compare
hasithaa
reviewed
Dec 12, 2024
...e-model-generator-core/src/main/java/io/ballerina/designmodelgenerator/core/CommonUtils.java
Outdated
Show resolved
Hide resolved
hasithaa
reviewed
Dec 12, 2024
...el-generator-core/src/main/java/io/ballerina/designmodelgenerator/core/model/Connection.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 33 out of 48 changed files in this pull request and generated 2 comments.
Files not reviewed (15)
- architecture-model-generator/modules/architecture-model-generator-core/build.gradle: Language not supported
- architecture-model-generator/modules/architecture-model-generator-ls-extension/build.gradle: Language not supported
- architecture-model-generator/modules/architecture-model-generator-core/src/main/java/module-info.java: Evaluated as low risk
- architecture-model-generator/modules/architecture-model-generator-core/src/main/java/io/ballerina/designmodelgenerator/core/DesignModelGenerator.java: Evaluated as low risk
- architecture-model-generator/modules/architecture-model-generator-core/src/main/java/io/ballerina/designmodelgenerator/core/ConnectionFinder.java: Evaluated as low risk
- architecture-model-generator/modules/architecture-model-generator-core/src/main/java/io/ballerina/designmodelgenerator/core/CommonUtils.java: Evaluated as low risk
- architecture-model-generator/modules/architecture-model-generator-core/src/main/java/io/ballerina/designmodelgenerator/core/model/Listener.java: Evaluated as low risk
- architecture-model-generator/modules/architecture-model-generator-core/src/main/java/io/ballerina/designmodelgenerator/core/model/Service.java: Evaluated as low risk
- architecture-model-generator/modules/architecture-model-generator-ls-extension/src/main/java/io/ballerina/desginmodelgenerator/extension/DesignModelGeneratorServerCapabilities.java: Evaluated as low risk
- architecture-model-generator/modules/architecture-model-generator-ls-extension/src/main/java/io/ballerina/desginmodelgenerator/extension/DesignModelGeneratorConstants.java: Evaluated as low risk
- architecture-model-generator/modules/architecture-model-generator-core/src/main/java/io/ballerina/designmodelgenerator/core/model/ResourceFunction.java: Evaluated as low risk
- architecture-model-generator/modules/architecture-model-generator-core/src/main/java/io/ballerina/designmodelgenerator/core/model/Connection.java: Evaluated as low risk
- architecture-model-generator/modules/architecture-model-generator-core/src/main/java/io/ballerina/designmodelgenerator/core/IntermediateModel.java: Evaluated as low risk
- architecture-model-generator/modules/architecture-model-generator-ls-extension/src/main/java/io/ballerina/desginmodelgenerator/extension/DesignModelGeneratorClientCapabilities.java: Evaluated as low risk
- architecture-model-generator/modules/architecture-model-generator-core/src/main/java/io/ballerina/designmodelgenerator/core/model/Function.java: Evaluated as low risk
Comments suppressed due to low confidence (1)
architecture-model-generator/modules/architecture-model-generator-core/src/main/java/io/ballerina/designmodelgenerator/core/model/DesignModel.java:0
- The new DesignModel class does not have any test coverage. Please add tests to cover the new behavior introduced by this class.
public record DesignModel(Automation automation, List<Connection> connections, List<Listener> listeners, List<Service> services) {
...odel-generator-core/src/main/java/io/ballerina/designmodelgenerator/core/model/Location.java
Outdated
Show resolved
Hide resolved
...o/ballerina/desginmodelgenerator/extension/DesignModelGeneratorClientCapabilitiesSetter.java
Outdated
Show resolved
Hide resolved
nipunayf
reviewed
Dec 17, 2024
...l-generator-core/src/main/java/io/ballerina/designmodelgenerator/core/model/DesignModel.java
Show resolved
Hide resolved
...-model-generator-core/src/main/java/io/ballerina/designmodelgenerator/core/CodeAnalyzer.java
Outdated
Show resolved
Hide resolved
...-model-generator-core/src/main/java/io/ballerina/designmodelgenerator/core/CodeAnalyzer.java
Outdated
Show resolved
Hide resolved
...-model-generator-core/src/main/java/io/ballerina/designmodelgenerator/core/CodeAnalyzer.java
Show resolved
Hide resolved
...el-generator-core/src/main/java/io/ballerina/designmodelgenerator/core/ConnectionFinder.java
Outdated
Show resolved
Hide resolved
...ion/src/main/java/io/ballerina/desginmodelgenerator/extension/response/AbstractResponse.java
Outdated
Show resolved
Hide resolved
nipunayf
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
$subject
Fixes issue