Skip to content

Conversation

@mwohlert
Copy link
Contributor

No description provided.

mwohlert and others added 4 commits October 23, 2019 21:08
Add rtl8189fs wifi driver as a breakout to be reused by others than just the orange pi lite

Changelog-entry: Add rtl8189fs wifi driver for orange pi lite
Signed-off-by: Michel Wohlert <[email protected]>
…d rtl8189fs as a module depdency for the orangepi-lite
@resin-jenkins
Copy link

Can one of the admins verify this patch?

@vicgal
Copy link
Contributor

vicgal commented Nov 4, 2019

Hi @mwohlert,

Thanks for contributing!
We already seem to have the 8189fs kernel module added for the orange pi lite
in meta-balena-allwinner/recipes-kernel/linux/linux-mainline_%.bbappend :

`
RESIN_CONFIGS_append_orange-pi-lite = "
8189fs
"

RESIN_CONFIGS[8189fs] ?= "
CONFIG_RTL8189FS=m
"
`
Are you having troubles with that? Is there a particular reason why you want to use the out of tree kernel module?

Kind regards

@mwohlert
Copy link
Contributor Author

mwohlert commented Nov 4, 2019

@vicgal Ah yes I see that. I suggest for that to be removed in favor of the standalone module, which I think is easier to maintain than a huge patch like the 8189 is: https://github.com/balena-os/balena-allwinner/blob/master/layers/meta-balena-allwinner/recipes-kernel/linux/linux-mainline/armbian/wifi-add-realtek-8189fs.patch

The 8189fs driver is already an out of tree module

@vicgal
Copy link
Contributor

vicgal commented Nov 5, 2019

@mwohlert, Ok, I see your point, but we don't actually maintain that patch since it's coming from Armbian. We have from them the kernel and the patches that come with it. If they update the kernel/patches, we follow through. If we were to have the OOT kernel module in our yocto layer, that would make us maintainers of the yocto recipe the least.

@vicgal vicgal requested a review from floion November 5, 2019 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants