Skip to content

Conversation

@ajlennon
Copy link

@ajlennon ajlennon commented Mar 6, 2019

Signed-off-by: Alex J Lennon [email protected]

@resin-jenkins
Copy link

Can one of the admins verify this patch?

@ajlennon ajlennon changed the title layers: add meta-sunxi-contrib for OrangePi-Plus2E WiFi support Add support for orangepi-plus2e Mar 6, 2019
@floion floion requested a review from a team March 14, 2019 05:34
@floion
Copy link
Contributor

floion commented Mar 14, 2019

@resin-jenkins ok to test

@floion
Copy link
Contributor

floion commented Mar 14, 2019

Hi @ajlennon thanks for the PR.
I have a few things to ask you.
Can you follow the contributions guideline from https://github.com/balena-os/balena-allwinner#pull-requests? (most notable, we need at least 1 Changelog-entry in one of your commits in this PR)
Also, can you split the PR in multiple commits, one for each file change?
Also, can you add community in the coffee file like in https://github.com/balena-os/balena-allwinner/blob/master/orange-pi-zero.coffee#L11?

@ajlennon
Copy link
Author

Will do! Thanks for the feedback

@ajlennon
Copy link
Author

#71

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants