Update config-to-label transform to include BALENA_* vars
#848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@balena-ci retest |
|
@balena-ci rebase |
ghost
force-pushed
the
update-strategy-vars
branch
from
a39ba76
to
46262a9
Compare
|
@balena-ci rebase |
ghost
force-pushed
the
update-strategy-vars
branch
from
46262a9
to
c50ba2e
Compare
|
@balena-ci rebase |
ghost
force-pushed
the
update-strategy-vars
branch
from
c50ba2e
to
e736b71
Compare
pipex
force-pushed
the
update-strategy-vars
branch
from
e736b71
to
225ae8d
Compare
[Documentation](https://www.balena.io/docs/learn/deploy/release-strategy/update-strategies/#controlling-the-update-strategy) mentions `BALENA_SUPERVISOR_UPDATE_STRATEGY` config var as a way to set the update strategy, but this var has no effect as there is no transform setup for it (there is only one for for `RESIN_` prefix). Change-type: patch Closes: #735
klutchell
force-pushed
the
update-strategy-vars
branch
from
225ae8d
to
2588ee3
Compare
|
@pipex anything blocking this, just a code review? |
|
Not that I know of @klutchell, is just missing a code review. I brought it up in a thread in FD here https://www.flowdock.com/app/rulemotion/r-product/threads/6lvSr_BMwEH9iw6pXX_t4qG4ACY, but I have not pushed more on this change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation mentions
BALENA_SUPERVISOR_UPDATE_STRATEGYconfig varas a way to set the update strategy, but this var has no effect as there
is no transform setup for it (there is only one for for
RESIN_prefix).Change-type: patch
Closes: #735