Fix v6 image.image_size no longer being a number #1738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thgreasi
changed the title
thgreasi
force-pushed
the
v6-number-image-image-size-
branch
4 times, most recently
from
43d566a
to
cd708ee
Compare
thgreasi
changed the title
thgreasi
force-pushed
the
v6-number-image-image-size-
branch
from
cd708ee
to
0308f6f
Compare
thgreasi
force-pushed
the
v6-number-image-image-size-
branch
2 times, most recently
from
8c6afed
to
d8fa262
Compare
thgreasi
commented
Sep 17, 2024
src/index.ts
Outdated
| */ | ||
| export const augmentedTypes = { | ||
| '@balena/sbvr-types': { | ||
| 'Numeric Big Integer': numericBigInteger, |
There was a problem hiding this comment.
This allows consumers to have their v6 model typings work without having to manually import the numeric-big-integer-hack (or redeclare the augmented typed).
We can perhaps in the future can start adding more typings here which we atm have only in oB, like balena-device-config.ts or even common.ts
Page-
reviewed
Sep 18, 2024
src/translations/v6/v6.sbvr
Outdated
| @@ -140,7 +140,7 @@ Term: image location | |||
| Concept Type: Short Text (Type) | |||
|
|
|||
| Term: image size | |||
| Concept Type: Big Integer (Type) | |||
| Concept Type: Integer (Type) | |||
There was a problem hiding this comment.
Any reason not to leave this as a big integer type here? It shouldn't affect anything other than knowing this is actually a big integer in the db rather than an integer when looking at it
Suggested change
| Concept Type: Integer (Type) | |
| Concept Type: Big Integer (Type) |
thgreasi
force-pushed
the
v6-number-image-image-size-
branch
2 times, most recently
from
8a889b0
to
6463e12
Compare
Page-
reviewed
Sep 20, 2024
thgreasi
force-pushed
the
v6-number-image-image-size-
branch
from
6463e12
to
e63f98c
Compare
Update @balena/pinejs from 19.0.0 to 19.0.1 Change-type: patch
Change-type: patch See: #1730
thgreasi
force-pushed
the
v6-number-image-image-size-
branch
from
e63f98c
to
ecf79f4
Compare
Page-
reviewed
Sep 24, 2024
Page-
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-type: patch
See: #1730
See: balena-io-modules/sbvr-types#106
See: https://balena.zulipchat.com/#narrow/stream/346007-balena-io.2FbalenaCloud/topic/v6.20image.2Eimage_size.20is.20now.20a.20string/near/465509436
See: https://balena.fibery.io/Work/Project/Fix-image-delta-size-no-longer-being-a-number-in-versions-v6-810