Change device heartbeat's redis prefix to device-heartbeat-state #1341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-type: patch
Change-type: patch
thgreasi
reviewed
May 5, 2023
| ).catch(() => { | ||
| // Ignore errors | ||
| }), | ||
| this.updateDeviceModel(deviceId, DeviceOnlineStates.Timeout), |
There was a problem hiding this comment.
Should we now move this before the scheduleChangeOfStateForDevice and stop using a Promise.all?
Since scheduleChangeOfStateForDevice runs in parallel, it might have already scheduled a new state change before updateDeviceModel throws, in which case the deleteMessageAsync at the end of the function will not be called, hence ending up w/ 2 messages about the same device in the queue (the old Online->Timeout that wasn't deleted and will be re-received, and the new Timeout->Offline).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-type: patch