Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update strategy and handover timeout not being detect with BALENA_ prefix #735

Open
20k-ultra opened this issue Aug 12, 2021 · 3 comments · May be fixed by #848
Open

update strategy and handover timeout not being detect with BALENA_ prefix #735

20k-ultra opened this issue Aug 12, 2021 · 3 comments · May be fixed by #848

Comments

@20k-ultra
Copy link

There is a legacy device configuration called SUPERVISOR_UPDATE_STRATEGY and SUPERVISOR_HANDOVER_TIMEOUT which are prefixed with RESIN_ or now BALENA_ however it only works with RESIN_. This is because of

open-balena-api/src/features/device-state/routes/state.ts

Lines 200 to 205 in 17f79c6

// These 2 config vars below are mapped to labels if missing for backwards-compatibility
// See: https://github.com/resin-io/hq/issues/1340
const ConfigurationVarsToLabels = {
RESIN_SUPERVISOR_UPDATE_STRATEGY: 'io.resin.update.strategy',
RESIN_SUPERVISOR_HANDOVER_TIMEOUT: 'io.resin.update.handover-timeout',
};
specifically looking for variables with RESIN_.
@20k-ultra
Copy link
Author

I'm just documenting this issue. We don't mind that this exists because this is just for backwards compatibility. If you encounter this issue you must set the update strategy in your services as a label in the docker-compose file: https://www.balena.io/docs/reference/supervisor/docker-compose/#labels.

This was referenced Aug 12, 2021
Open
Closed
@pipex pipex reopened this Nov 12, 2021
@pipex
Copy link
Contributor

pipex commented Nov 12, 2021

Reopening this issue since there is no resolution either in the documentation or the API.

Although it is true that the way the supervisor understands release strategies is through labels, the we have also discussed having application level release strategies (see balena-os/balena-supervisor#1103) and this method would be compatible with that, so I'm not entirely sure we want to move away from this method.

The simplest short term solution seems to be to update the code linked by @20k-ultra including the BALENA_SUPERVISOR_UPDATE_STRATEGY and BALENA_SUPERVISOR_HANDOVER_TIMEOUT

@jellyfish-bot
Copy link

[inspaya] This issue has attached support thread https://jel.ly.fish/b1dd2ce2-1a3f-4809-b9bc-b821fa7b9073

pipex added a commit that referenced this issue Nov 12, 2021
@pipex
Update config-to-label transform to include BALENA_* vars
a39ba76 
[Documentation](https://www.balena.io/docs/learn/deploy/release-strategy/update-strategies/#controlling-the-update-strategy)
mentions `BALENA_SUPERVISOR_UPDATE_STRATEGY` config var
as a way to set the update strategy, but this var has no effect as there
is no transform setup for it (there is only one for for `RESIN_` prefix).

Change-type: patch
Closes: #735
@pipex pipex linked a pull request Nov 12, 2021 that will close this issue
Open
ghost pushed a commit that referenced this issue Nov 16, 2021
@pipex
Update config-to-label transform to include BALENA_* vars
46262a9 
[Documentation](https://www.balena.io/docs/learn/deploy/release-strategy/update-strategies/#controlling-the-update-strategy)
mentions `BALENA_SUPERVISOR_UPDATE_STRATEGY` config var
as a way to set the update strategy, but this var has no effect as there
is no transform setup for it (there is only one for for `RESIN_` prefix).

Change-type: patch
Closes: #735
ghost pushed a commit that referenced this issue Nov 16, 2021
@pipex
Update config-to-label transform to include BALENA_* vars
c50ba2e 
[Documentation](https://www.balena.io/docs/learn/deploy/release-strategy/update-strategies/#controlling-the-update-strategy)
mentions `BALENA_SUPERVISOR_UPDATE_STRATEGY` config var
as a way to set the update strategy, but this var has no effect as there
is no transform setup for it (there is only one for for `RESIN_` prefix).

Change-type: patch
Closes: #735
ghost pushed a commit that referenced this issue Nov 19, 2021
@pipex
Update config-to-label transform to include BALENA_* vars
e736b71 
[Documentation](https://www.balena.io/docs/learn/deploy/release-strategy/update-strategies/#controlling-the-update-strategy)
mentions `BALENA_SUPERVISOR_UPDATE_STRATEGY` config var
as a way to set the update strategy, but this var has no effect as there
is no transform setup for it (there is only one for for `RESIN_` prefix).

Change-type: patch
Closes: #735
pipex added a commit that referenced this issue Mar 18, 2022
@pipex
Update config-to-label transform to include BALENA_* vars
225ae8d 
[Documentation](https://www.balena.io/docs/learn/deploy/release-strategy/update-strategies/#controlling-the-update-strategy)
mentions `BALENA_SUPERVISOR_UPDATE_STRATEGY` config var
as a way to set the update strategy, but this var has no effect as there
is no transform setup for it (there is only one for for `RESIN_` prefix).

Change-type: patch
Closes: #735
@pipex pipex mentioned this issue Mar 18, 2022
Open
klutchell pushed a commit that referenced this issue Apr 25, 2022
@pipex @klutchell
Update config-to-label transform to include BALENA_* vars
2588ee3 
[Documentation](https://www.balena.io/docs/learn/deploy/release-strategy/update-strategies/#controlling-the-update-strategy)
mentions `BALENA_SUPERVISOR_UPDATE_STRATEGY` config var
as a way to set the update strategy, but this var has no effect as there
is no transform setup for it (there is only one for for `RESIN_` prefix).

Change-type: patch
Closes: #735
@pipex pipex mentioned this issue May 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update config-to-label transform to include BALENA_* vars balena-io/open-balena-api
3 participants
@pipex @20k-ultra @jellyfish-bot