Add $count option to get api keys methods #1293
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-type: minor Signed-off-by: Andrea Rosci <[email protected]>
thgreasi
reviewed
Jan 24, 2023
| name: { | ||
| $ne: null, | ||
| }, | ||
| ): Promise<BalenaSdk.ApiKey[] | number> { |
There was a problem hiding this comment.
I think it would be better to keep this in the UI atm, otherwise in order to get it in the SDK we need to define overloads for the methods, so that when TS sees that $count is defined it then uses the overload that returns a number.
You can check the .get() pinejs-client typings in the SDK to check how we defined the overloads for when ParamsObjWithCount is provided.
thgreasi
reviewed
Jan 24, 2023
Comment on lines
+286
to
289
| $count: { | ||
| ...internalOptions, | ||
| ...options.$count, | ||
| }, |
There was a problem hiding this comment.
Shouldn't this be v ?
Suggested change
| $count: { | |
| ...internalOptions, | |
| ...options.$count, | |
| }, | |
| $count: mergePineOptions(internalOptions, options.$count), |
Applies in all methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-type: minor
Signed-off-by: Andrea Rosci [email protected]
Contributor checklist