Update base32 user land implementation

bakame-php · Apr 1, 2024 · 4042d4b · 4042d4b
1 parent 216edc0
commit 4042d4b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/Base32.php b/Base32.php
@@ -194,10 +194,6 @@ private function prepareDecoding(string $encoded, bool $strict): array
             $encoded = str_replace($padding, '', $inside).$end;
         }
 
-        if ('' === $encoded) {
-            return [$encoded, $alphabet, $padding];
-        }
-
         $remainder = strlen($encoded) % 8;
         if (0 !== $remainder) {
             if ($strict) {

diff --git a/Base32Test.php b/Base32Test.php
@@ -124,6 +124,7 @@ public static function base32decodeAsciiDataProvider(): array
         return [
             ...self::base32encodeAsciiDataProvider(),
             'All Invalid Characters' => ['', '8908908908908908'],
+            'empty Characters' => ['', '         '],
         ];
     }
 
@@ -158,6 +159,7 @@ public static function base32decodeHexDataProvider(): array
         return [
             ...self::base32encodeHexDataProvider(),
             'All Invalid Characters' => ['', 'WXYXWXYZWXYZWXYZ'],
+            'empty Characters' => ['', '         '],
         ];
     }