bugfix: counter cannot compact in mem leveldb #1283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
May 19, 2017 10:59
taocp
reviewed
Jun 7, 2017
| @@ -542,6 +550,10 @@ void Version::GetOverlappingInputs( | |||
| } | |||
| } | |||
| } | |||
| if (strategy != NULL) { | |||
There was a problem hiding this comment.
（可以不用判断NULL，直接delete；加上判断也行，随你。）
| virtual void FindShortestSeparator( | ||
| std::string* start, | ||
| const Slice& limit) const { | ||
| return; |
There was a problem hiding this comment.
直接 {} 就行了，可以不用再写return;
和现有代码的风格保持一致
|
LGTM |
1 similar comment
|
LGTM |
taocp
approved these changes
Jun 7, 2017
caijieming-ng
pushed a commit
that referenced
this pull request
Jun 23, 2017
cherry-pick from bb9be4f bugfix:counter cannot compact in mem leveldb ( * add code review and merge code rule * add code review and merge code rule * add code review and merge code rule * add code review and merge code rule * bugfix: counter cannot compact in mem leveldb
caijieming-ng
pushed a commit
that referenced
this pull request
Jun 23, 2017
* add code review and merge code rule * add code review and merge code rule * add code review and merge code rule * add code review and merge code rule * bugfix: counter cannot compact in mem leveldb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.