Bacpop-159 v8 db update #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5 +/- ##
=======================================
Coverage ? 92.35%
=======================================
Files ? 2
Lines ? 170
Branches ? 0
=======================================
Hits ? 157
Misses ? 13
Partials ? 0 ☔ View full report in Codecov by Sentry. |
| @@ -176,9 +174,6 @@ def api_configure(container, cfg): | |||
| else: | |||
| print("[api] Downloading storage database") | |||
| args = ["./scripts/download_db"] | |||
| if cfg.api_use_small_db: | |||
| args = args + ["--small"] | |||
| args = args + ["storage"] | |||
There was a problem hiding this comment.
I think we can still include the storage line - though it looks like in the script, the storage location defaults to that anyway, we might as well keep this in to make the link with the volume clearer.
There was a problem hiding this comment.
ive removed this from beebop_py so the script doesn't accept arg
EmmaLRussell
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.