bacpop-150 Staging config #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmmaLRussell
commented
Feb 16, 2024
config/prod.yml
Outdated
Comment on lines
4
to
5
| certificate: VAULT:secret/beebop/ssl/production:cert | ||
| key: VAULT:secret/beebop/ssl/production:key |
There was a problem hiding this comment.
We've added an additional level to keep ssl values for different servers (production and staging).
richfitz
reviewed
Feb 22, 2024
.github/workflows/Pytest.yml
Outdated
| branches: | ||
| - main | ||
| - master | ||
| on: push |
There was a problem hiding this comment.
It wasn't building this branch as targeting bacpop-143..
There was a problem hiding this comment.
on:
push:
branches:
- main
- master
- "bacpop-*"
pull_request:
branches:
- main
- master
- "bacpop-*"
I set this pattern up in mcstate2 and it's working well (mrc-ide/monty@d267d0e)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4 +/- ##
=======================================
Coverage ? 92.52%
=======================================
Files ? 2
Lines ? 174
Branches ? 0
=======================================
Hits ? 161
Misses ? 13
Partials ? 0 ☔ View full report in Codecov by Sentry. |
richfitz
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds config for beebop-dev.dide.ic.ac.uk
Contains commits from #3 so is pulling in v6 database.