forked from react-native-community/upgrade-helper
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
POC Changelog viewer #21
Open
Sarabadu
wants to merge
111
commits into
backstage:master
Choose a base branch
from
Sarabadu:changelog
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Nicola Corti <[email protected]>
Co-authored-by: Tommy Nguyen <[email protected]>
Co-authored-by: Adam Foxman <[email protected]>
previously on a comparison page like this one [1], we were having an issue, where the changelog link was not set. this was due to the package name not being accessible for the "UsefulLinks" component. this commit fixes this issue [1]: https://react-native-community.github.io/upgrade-helper/?from=0.63.4&to=0.69.0
Bumps [terser](https://github.com/terser/terser) from 4.4.3 to 4.8.1. - [Release notes](https://github.com/terser/terser/releases) - [Changelog](https://github.com/terser/terser/blob/master/CHANGELOG.md) - [Commits](https://github.com/terser/terser/commits) --- updated-dependencies: - dependency-name: terser dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Also updates the UsefulLinks class to a functional component
Fix the CompletedFilesCounter test
When running `yarn start`, the console would complain: WARNING in ./node_modules/react-diff-view/es/index.js Module Warning (from ./node_modules/source-map-loader/dist/cjs.js): Failed to parse source map from ‘~/react-native-upgrade-helper/node_modules/react-diff-view/src/utils/parse.ts' file: Error: ENOENT: no such file or directory, open ‘~/react-native-upgrade-helper/node_modules/react-diff-view/src/utils/parse.ts'
Signed-off-by: Juan Pablo Garcia Ripa <[email protected]>
Signed-off-by: Juan Pablo Garcia Ripa <[email protected]>
Signed-off-by: Juan Pablo Garcia Ripa <[email protected]>
Signed-off-by: Juan Pablo Garcia Ripa <[email protected]>
Signed-off-by: Juan Pablo Garcia Ripa <[email protected]>
Signed-off-by: Juan Pablo Garcia Ripa <[email protected]>
Signed-off-by: Juan Pablo Garcia Ripa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The upgrade helper really makes the most common changes easier to be highlighted, but for the changes that are not in the create-app we have 2 cases:
In this POC we are adding a new route that gets the package name and version as part of the url and queries the changelog file for that package and version from npm (just
CHANGELOG.md
for now, maybe requires more posible names in the future.How it looks
You can see it working here https://sarabadu.github.io/upgrade-helper/changelog/@backstage-community/plugin-announcements/0.1.2 , changing the packages and versions
Thoughts
next
version changesTest Plan
What are the steps to reproduce?
Checklist
README.md
(if needed)