Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

blackduck - Removed usages and references of @backstage/backend-common #1975

Closed
wants to merge 2 commits into from
Closed

blackduck - Removed usages and references of @backstage/backend-common #1975

wants to merge 2 commits into from

Conversation

awanlin
Copy link
Contributor

@awanlin awanlin commented Nov 17, 2024

Hey, I just made a Pull Request!

Removed usages and references of @backstage/backend-common

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

@awanlin awanlin requested a review from a team as a code owner November 17, 2024 19:37
@awanlin
Copy link
Contributor Author

awanlin commented Nov 17, 2024

Hi @deepan10, I think this is one of your plugins, right? If so can you give it a look, please?

@backstage-goalie
Copy link
Contributor

Changed Packages

Package Name Package Path Changeset Bump Current Version
backend workspaces/blackduck/packages/backend none v0.0.7
@backstage-community/plugin-blackduck-backend workspaces/blackduck/plugins/blackduck-backend patch v0.0.7
@backstage-community/plugin-blackduck workspaces/blackduck/plugins/blackduck patch v0.0.6

@deepan10
Copy link
Member

Hello @awanlin
Its pretty clear and I tested it, All good with this change.

@awanlin
Added deprecation
a654561 
Signed-off-by: Andre Wanlin <[email protected]>
@awanlin awanlin closed this Nov 20, 2024
@awanlin
Copy link
Contributor Author

awanlin commented Nov 20, 2024

Reason for closing outlined here: #1176 (comment)

@awanlin awanlin deleted the blackduck/remove-backend-common branch November 20, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinzscam vinzscam Awaiting requested review from vinzscam vinzscam is a code owner automatically assigned from backstage/community-plugins-maintainers

@deepan10 deepan10 Awaiting requested review from deepan10 deepan10 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@awanlin @deepan10