Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(npm): export deprecated card components to be backward compatible #1751

Merged
merged 3 commits into from
Oct 24, 2024

Conversation

christoph-jerolimov
Copy link
Member

Hey, I just made a Pull Request!

Export NpmInfoCard, NpmReleaseOverviewCard and NpmReleaseTableCard as deprecated components after these component was renamed in #1516

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

@backstage-goalie
Copy link
Contributor

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage-community/plugin-npm workspaces/npm/plugins/npm patch v1.0.1

Signed-off-by: Christoph Jerolimov <[email protected]>
Copy link
Contributor

@awanlin awanlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good, again sorry that I caused this issue for you 🙏

@christoph-jerolimov
Copy link
Member Author

christoph-jerolimov commented Oct 23, 2024

@awanlin I like to update the README as well. Can I add another commit in < 5 min or should I open another PR?

Signed-off-by: Christoph Jerolimov <[email protected]>
@christoph-jerolimov
Copy link
Member Author

christoph-jerolimov commented Oct 23, 2024

Added it here. Hope that's fine. From my side, this is ready to merge.

Again thanks that you spend so much time of your evening for this. 🙏

@awanlin awanlin merged commit fa1521c into backstage:main Oct 24, 2024
11 checks passed
@christoph-jerolimov christoph-jerolimov deleted the fix-npm-exports branch October 24, 2024 00:09
@christoph-jerolimov christoph-jerolimov self-assigned this Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants