Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(npm): make plugin public to get published on npm #1716

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

christoph-jerolimov
Copy link
Member

Hey, I just made a Pull Request!

This reverts the PR #1662 that published the npm plugin 1.0.0 as it wasn't published because the plugin package.json contained private: true by accident (after migrating a private plugin to this repo).

The 2nd commit changed it to a public package to get released this time on npm. 🥳

I cross the fingers that it will not fail because there is already a tag https://github.com/backstage/community-plugins/releases/tag/%40backstage-community%2Fplugin-npm%401.0.0 🤔

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

@backstage-goalie
Copy link
Contributor

Changed Packages

Package Name Package Path Changeset Bump Current Version
app workspaces/npm/packages/app none v0.0.0
@backstage-community/plugin-npm workspaces/npm/plugins/npm major v0.1.0

@christoph-jerolimov
Copy link
Member Author

@nickboldt nickboldt merged commit 394506b into backstage:main Oct 21, 2024
11 checks passed
@awanlin
Copy link
Contributor

awanlin commented Oct 21, 2024

Hi @christoph-jerolimov and @nickboldt, there already was a PR for this #1516. Can you please make sure to check before you rush out like this?

@christoph-jerolimov
Copy link
Member Author

Thanks for getting this in.

@awanlin no worries, the initial idea of #1516 was to extent the plugin with a dev page. And I asked the author (and coworker) to make the adjustments to fix the release.

But now the other pr needs a rebase anyway. In this case I guessing it was fine to move forward to get this finally released. And I will check with Karthik to get 1516 in after an update.

Thanks anyway for all your reviews and help to align this for all plugins!

@christoph-jerolimov christoph-jerolimov deleted the fix-npm-release-1-0-0 branch October 22, 2024 06:23
@christoph-jerolimov christoph-jerolimov self-assigned this Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants