add flag in new runtime class to reduce tracing excludes while class …#3
Open
bkihm wants to merge 1 commit intobackes:masterfrom
Open
add flag in new runtime class to reduce tracing excludes while class …#3bkihm wants to merge 1 commit intobackes:masterfrom
bkihm wants to merge 1 commit intobackes:masterfrom
Conversation
Owner
|
Thanks for the pull request. Interesting, how easy this seems to be :) Your solution seems to be a bit of an overkill though. The current implementation already creates an uninstrumented copy of each method, which is used if the current tracer is paused (see TracingMethodInstrumenter). It would be far easier to just add the check for the global flag there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…transformation