Skip to content

Conversation

@bugfolder
Copy link

Fixes #1.

index.php Outdated
* Print the HTML for a single table row.
*/
function create_row($name, $db_path, $file_path) {
function create_row($name, $db_path, $db_civi_path, $file_path) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we make the new argument the last one? We won't have civi for most of our sites, and it would be easier not to need to pass NULL when backing up the docs site (for example).

Copy link
Author

@bugfolder bugfolder Dec 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, happy to swap the arguments (see revised PR). I will note that when we pass '' (not NULL), that happens automatically (or not) based on whether there's a CiviCRM db backup in place, so that this works currently for all four properties.

And then if we decide to add CiviCRM to, for example, the events site (to do event registrations), all we'd have to do, backup/sanitation-wise, is add the *_CIVI settings to the config.ini file on events.b.org, use the current sql-dump-sanitize.php script, and add the symlink to the sanitized_civi directory, and this function will start showing the Civi backups automatically as they start to be created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update the download page to include CiviCRM sanitized backups

2 participants