Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Depandabot Auto Merges and CircleCI References #4660

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

jamlo
Copy link
Contributor

@jamlo jamlo commented Oct 24, 2024

Currently We have multiple implementation of Dependabot, one of them did not run for months, and the default one keeps failing. Also, Circle CI is still being referenced for some reason in the Dependabot flow.

For this PR:

  1. Remove auto-merge logic for Dependabot until we consolidate CI to Github Actions. The auto-merge setup had many bugs, as well as duplicate functionality.
  2. For now, rely of the PRs created by Depandabot, and we will do manual PR reviews and merges for the PRs created by Depandabot.
  3. When all of the CI is consolidated to Github Actions, we can bring back the automatic Depandabot merges, in a cleaner way.
  4. Remove any CircleCI References. It is confusing to keep them around for no reason.

1. We have multiple implementation of Dependabot, one of them did not
run for months, and the default one keeps failing. Also, Circle CI
is still being referenced for some reason in the Dependabot flow.

2. Rely of the PRs created by Depandabot, and will will do manual PR
reviews and merges for now.

3. When all of the CI is consolidated to Github Actions, we can
bring automatic Depandabot merges, in a cleaner way.

4. Remove any CircleCI References

Linear Issue: https://linear.app/expanso/issue/ENG-297/fix-dependabot-integration
Github Issue: #4656
Copy link

linear bot commented Oct 24, 2024

@jamlo jamlo marked this pull request as ready for review October 24, 2024 17:51
@jamlo jamlo requested a review from wdbaruni October 24, 2024 17:51
@jamlo jamlo changed the title Remove Depandabot Auto Merges and any CircleCI References Remove Depandabot Auto Merges and CircleCI References Oct 24, 2024
Since we are not using Circle CI anymore, remove the .circleci from the
repository since it is adding to the confusion.

Linear Issue: https://linear.app/expanso/issue/ENG-297/fix-dependabot-integration
Github Issue: #4656
uses: actions/setup-go@v5
with:
go-version: ${{ env.GOLANG_TEST_VERSION }}
cache: true
go-version-file: go.work
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@jamlo jamlo merged commit 1ad6d34 into main Oct 24, 2024
5 checks passed
@jamlo jamlo deleted the eng-297/jamlo/fix-depandabot-integration branch October 24, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants