fix: only collect OS type; fix method name; add readme #4579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frrist
commented
Oct 2, 2024
| @@ -0,0 +1,118 @@ | |||
| # What Data is shared by users of Bacalhau? | |||
There was a problem hiding this comment.
@seanmtracey @aronchick is here is README on the data being collected, along with steps to opt out. Feedback welcome.
frrist
commented
Oct 2, 2024
| @@ -260,7 +260,7 @@ func serve(cmd *cobra.Command, cfg types.Bacalhau, fsRepo *repo.FsRepo) error { | |||
|
|
|||
| if !cfg.DisableAnalytics { | |||
| err = analytics.SetupAnalyticsProvider(ctx, | |||
| analytics.WithNodeNodeID(sysmeta.NodeName), | |||
| analytics.WithNodeID(sysmeta.NodeName), | |||
There was a problem hiding this comment.
@wdbaruni is collecting the name of the node acceptable, just want to double check. Would it be better to use the hash of the name instead?
frrist
commented
Oct 2, 2024
| resource.WithOS(), | ||
| resource.WithOSType(), |
There was a problem hiding this comment.
@wdbaruni I have reduced the information collected here (from what was requested in the initial POC) to just the operating system type. Prior to this change, this field contained data like:
Linux cypress 6.8.0-40-generic #40~22.04.3-Ubuntu SMP PREEMPT_DYNAMIC Tue Jul 30 17:30:19 UTC 2 x86_64 x86_64 x86_64 GNU/Linux
Which is beyond the scope of the information we want to share.
wdbaruni
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: