Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix orchestrator showing as disconnected #4567

Merged
merged 2 commits into from
Oct 1, 2024
Merged

fix orchestrator showing as disconnected #4567

merged 2 commits into from
Oct 1, 2024

Conversation

wdbaruni
Copy link
Member

@wdbaruni wdbaruni commented Oct 1, 2024

orchestrator node doesn't heartbeat which results in its state showing as disconnected in the webUI and http APIs. This PR fixes this by having the orchestrator node treats itself as connected regardless of heartbeats or not. We might have to introduce orchestrator level heartbeats in the future when we introduce multiple orchestrators

Testing done

  • Unit tests
  • Verified WebUI is showing the right state
  • Verified compute nodes are still marked as disconnected when they go down

@wdbaruni wdbaruni requested a review from udsamani October 1, 2024 07:03
@wdbaruni wdbaruni self-assigned this Oct 1, 2024
@wdbaruni wdbaruni merged commit 83df3e9 into main Oct 1, 2024
3 of 4 checks passed
@wdbaruni wdbaruni deleted the connected-state branch October 1, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants