Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] v2 config and node construction #4328

Closed
wants to merge 2 commits into from

Conversation

frrist
Copy link
Contributor

@frrist frrist commented Aug 14, 2024

Supports: #4014

In this PR I have implemented a v2 config type and v2 node package that consumes the new config when constructing a node. Further, it has decoupled paths in the config from the repo. The result this is a new package that may be used to construct a bacalhau node based on the new config; Creating a functioning bacalhau node that operates as expected.

  • It doesn't pass tests - primarily because our old configuration structure is deeply woven into our test setup, pseudo-dependency-injection, and because we are removing/changing many fields in the new config e.g.
    • We currently have several (too many) different config types that are used to construct a node - types.BacalhauConfig, types.RequesterConfig, types.ComputeConfig , node.NodeConfig, node.RequesterConfig, node.ComputeConfig, node.NetworkConfig plus each package implements it's own default version and testing version of is respective config.
      • For example, the current node construction code accepts both types.BacalhauConfig and node.NodeConfig using fields from each for various configuration.
    • When writing tests we modify various fields of these config to affect the node construction necessitated by the test.
    • We include testing fields in our configs, like FailureInjectionConfig which are not present in our new config struct (and shouldn't be)
    • We've removed many fields in the new config like JobExecutionTimeoutClientIDBypassList, RejectStatelessJobs, ProbeExec, ProbeHTTP , MaxJobExecutionTimeout, MinJobExecutionTimeout, etc. which we have test coverage for that needs to be removed.

The high level plan here is to start pulling pieces out of this large PR into smaller ones:

frrist added 2 commits July 18, 2024 14:40
Copy link
Contributor

coderabbitai bot commented Aug 14, 2024

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant