Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow node list to sort and filter by approval status #3685

Merged
merged 3 commits into from
Mar 23, 2024

Conversation

rossjones
Copy link
Contributor

@rossjones rossjones commented Mar 22, 2024

When calling node list, it is possible to sort by various fields, but it is not possible to sort by approval status.
Supports 'approval' (as an alias) and 'status' for --order-by when calling node list. This also work when specifying --order-reversed.

bacalhau node list --order-by status 
bacalhau node list --order-by status --order-reversed 

In addition to sorting, it is also possible to only return nodes with a specific status. This is also applied when filtering by labels.

bacalhau node list --filter-status approved 
bacalhau node list --filter-status approved  --labels env=devstack

Resolves #3682

Copy link
Contributor

coderabbitai bot commented Mar 22, 2024

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.


Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@rossjones rossjones changed the title Allow node list to sort by approval status WIP Allow node list to sort by approval status Mar 22, 2024
@rossjones rossjones changed the title WIP Allow node list to sort by approval status Allow node list to sort and filter by approval status Mar 22, 2024
@rossjones rossjones requested a review from a team March 22, 2024 12:06
Copy link
Collaborator

@aronchick aronchick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - well done, great fast turn around

@rossjones rossjones force-pushed the list-sort-by-approval branch from ec3cf28 to d83d324 Compare March 23, 2024 19:07
@rossjones rossjones enabled auto-merge (squash) March 23, 2024 19:08
@rossjones rossjones merged commit 11181d3 into main Mar 23, 2024
12 checks passed
@rossjones rossjones deleted the list-sort-by-approval branch March 23, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need: bacalhau approve --list
2 participants