[Documentation] add notes about registries and architecture #3316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rossjones
reviewed
Jan 25, 2024
| ## Notes | ||
|
|
||
| - Currently, only images published to public registries are supported. Make sure your image is available in one of them, for example DockerHub, ghcr. Locally hosted registries are not supported. |
There was a problem hiding this comment.
I misunderstood the question. It might be worth trying something like ..
Suggested change
| - Currently, only images published to public registries are supported. Make sure your image is available in one of them, for example DockerHub, ghcr. Locally hosted registries are not supported. | |
| - Currently, only images published to public registries are supported. Make sure your image is available in one of them, for example DockerHub, or ghcr. Private images can be retrieved from docker hub by [specifying your credentials](/running-node/quick-start-docker/#authenticate-with-docker-hub) |
I've removed the bit about locally hosted registries because we haven't yet confirmed either way whether they work or not.
rossjones
added
the
th/documentation
rossjones
approved these changes
Jan 31, 2024
MichaelHoepler
merged commit e045de2
into
bacalhau-project:docupdating-a1qa
7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarify the architecture and registry details