Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add authentication that supports usernames and passwords #3311

Merged
merged 1 commit into from
Jan 26, 2024
Merged

Conversation

simonwo
Copy link
Contributor

@simonwo simonwo commented Jan 25, 2024

This commit adds ask mode authentication that allows node operators to configure Bacalhau to ask the user for arbitrary information to be used as a credential.

This method can be used to implement basic usernames and passwords, shared secrets, security questions and even 2FA.

The associated policy additionally returns a JSON Schema to show what information is required. The CLI uses the schema to ask the user for the right information. In the future, the Web UI will do this as well.

Resolves https://github.com/bacalhau-project/expanso-planning/issues/342.
Resolves https://github.com/bacalhau-project/expanso-planning/issues/343.

@simonwo simonwo requested review from rossjones and frrist January 25, 2024 04:57
@simonwo simonwo force-pushed the authz-1 branch 2 times, most recently from d9cb0ab to 663e7fb Compare January 25, 2024 05:38
rossjones
rossjones previously approved these changes Jan 25, 2024
Copy link
Contributor

@rossjones rossjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

docs/docs/running-node/auth.md Outdated Show resolved Hide resolved
docs/docs/running-node/auth.md Outdated Show resolved Hide resolved
This commit adds `ask` mode authentication that allows node operators
to configure Bacalhau to ask the user for arbitrary information to be
used as a credential.

This method can be used to implement basic usernames and passwords,
shared secrets, security questions and even 2FA.

The associated policy additionally returns a JSON Schema to show what
information is required. The CLI uses the schema to ask the user for
the right information. In the future, the Web UI will do this as well.
@simonwo
Copy link
Contributor Author

simonwo commented Jan 25, 2024

@simonwo simonwo dismissed rossjones’s stale review via ba29c90

??? I didn't do this...

@simonwo simonwo merged commit a859785 into main Jan 26, 2024
11 checks passed
@simonwo simonwo deleted the authz-1 branch January 26, 2024 12:10
@rossjones
Copy link
Contributor

??? I didn't do this...

Has someone turned in "dismiss stale reviews with each push" ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants