Docupdating a1qa into main #3227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 62149b8.
…t/bacalhau into docupdating-a1qa
- require will cause the test to fail immediately if conditions are not met. We should fail all tests using teststack if the nodes are not connected to each other. The previous behavior used `assert` which resulted in tests with improperly bootstrapped teststacks continuing, leading to confusing error messages regarding test failures.
- error is return whilst IPFS is fetching content to determine volume size - closes #3085
The GPU index is self reported and not guaranteed to be unique across different GPU vendors. This was causing labels from different vendors to collide and override each other.
- We don't need to init tools for test or build anymore, because these jobs don't do anything with Python or Node anymore. - We don't need to build the binary before running tests, which also saves installing the Node modules and building the Web UI.
These were only needed by the swagger embedded server which we don't use.
Bumps [github.com/labstack/echo/v4](https://github.com/labstack/echo) from 4.11.1 to 4.11.3. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/labstack/echo/releases">github.com/labstack/echo/v4's releases</a>.</em></p> <blockquote> <h2>v4.11.3</h2> <p><strong>Security</strong></p> <ul> <li>'c.Attachment' and 'c.Inline' should escape filename in 'Content-Disposition' header to avoid 'Reflect File Download' vulnerability. <a href="https://redirect.github.com/labstack/echo/pull/2541">#2541</a></li> </ul> <p><strong>Enhancements</strong></p> <ul> <li>Tests: refactor context tests to be separate functions <a href="https://redirect.github.com/labstack/echo/pull/2540">#2540</a></li> <li>Proxy middleware: reuse echo request context <a href="https://redirect.github.com/labstack/echo/pull/2537">#2537</a></li> <li>Mark unmarshallable yaml struct tags as ignored <a href="https://redirect.github.com/labstack/echo/pull/2536">#2536</a></li> </ul> <h2>v4.11.2</h2> <p><strong>Security</strong></p> <ul> <li>Bump golang.org/x/net to prevent CVE-2023-39325 / CVE-2023-44487 HTTP/2 Rapid Reset Attack <a href="https://redirect.github.com/labstack/echo/pull/2527">#2527</a></li> <li>fix(sec): randomString bias introduced by <a href="https://redirect.github.com/labstack/echo/issues/2490">#2490</a> <a href="https://redirect.github.com/labstack/echo/pull/2492">#2492</a></li> <li>CSRF/RequestID mw: switch math/random usage to crypto/random <a href="https://redirect.github.com/labstack/echo/pull/2490">#2490</a></li> </ul> <p><strong>Enhancements</strong></p> <ul> <li>Delete unused context in body_limit.go <a href="https://redirect.github.com/labstack/echo/pull/2483">#2483</a></li> <li>Use Go 1.21 in CI <a href="https://redirect.github.com/labstack/echo/pull/2505">#2505</a></li> <li>Fix some typos <a href="https://redirect.github.com/labstack/echo/pull/2511">#2511</a></li> <li>Allow CORS middleware to send Access-Control-Max-Age: 0 <a href="https://redirect.github.com/labstack/echo/pull/2518">#2518</a></li> <li>Bump dependancies <a href="https://redirect.github.com/labstack/echo/pull/2522">#2522</a></li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/labstack/echo/blob/master/CHANGELOG.md">github.com/labstack/echo/v4's changelog</a>.</em></p> <blockquote> <h2>v4.11.3 - 2023-11-07</h2> <p><strong>Security</strong></p> <ul> <li>'c.Attachment' and 'c.Inline' should escape filename in 'Content-Disposition' header to avoid 'Reflect File Download' vulnerability. <a href="https://redirect.github.com/labstack/echo/pull/2541">#2541</a></li> </ul> <p><strong>Enhancements</strong></p> <ul> <li>Tests: refactor context tests to be separate functions <a href="https://redirect.github.com/labstack/echo/pull/2540">#2540</a></li> <li>Proxy middleware: reuse echo request context <a href="https://redirect.github.com/labstack/echo/pull/2537">#2537</a></li> <li>Mark unmarshallable yaml struct tags as ignored <a href="https://redirect.github.com/labstack/echo/pull/2536">#2536</a></li> </ul> <h2>v4.11.2 - 2023-10-11</h2> <p><strong>Security</strong></p> <ul> <li>Bump golang.org/x/net to prevent CVE-2023-39325 / CVE-2023-44487 HTTP/2 Rapid Reset Attack <a href="https://redirect.github.com/labstack/echo/pull/2527">#2527</a></li> <li>fix(sec): randomString bias introduced by <a href="https://redirect.github.com/labstack/echo/issues/2490">#2490</a> <a href="https://redirect.github.com/labstack/echo/pull/2492">#2492</a></li> <li>CSRF/RequestID mw: switch math/random usage to crypto/random <a href="https://redirect.github.com/labstack/echo/pull/2490">#2490</a></li> </ul> <p><strong>Enhancements</strong></p> <ul> <li>Delete unused context in body_limit.go <a href="https://redirect.github.com/labstack/echo/pull/2483">#2483</a></li> <li>Use Go 1.21 in CI <a href="https://redirect.github.com/labstack/echo/pull/2505">#2505</a></li> <li>Fix some typos <a href="https://redirect.github.com/labstack/echo/pull/2511">#2511</a></li> <li>Allow CORS middleware to send Access-Control-Max-Age: 0 <a href="https://redirect.github.com/labstack/echo/pull/2518">#2518</a></li> <li>Bump dependancies <a href="https://redirect.github.com/labstack/echo/pull/2522">#2522</a></li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/labstack/echo/commit/4b26cde851bc7a51e624c04dcc5d37be1ce0c84f"><code>4b26cde</code></a> Changelog for v4.11.3 (<a href="https://redirect.github.com/labstack/echo/issues/2542">#2542</a>)</li> <li><a href="https://github.com/labstack/echo/commit/14daeb968049b71296a80b91abd3883afd02b4d1"><code>14daeb9</code></a> Security: c.Attachment and c.Inline should escape name in `Content-Dispositio...</li> <li><a href="https://github.com/labstack/echo/commit/50ebcd8d7c17457489df7bcbbcaa3745c687fd32"><code>50ebcd8</code></a> refactor context tests to be separate functions (<a href="https://redirect.github.com/labstack/echo/issues/2540">#2540</a>)</li> <li><a href="https://github.com/labstack/echo/commit/c7d6d4373fdfbef5d6f44df0a8ef410c198420ee"><code>c7d6d43</code></a> proxy middleware: reuse echo request context (<a href="https://redirect.github.com/labstack/echo/issues/2537">#2537</a>)</li> <li><a href="https://github.com/labstack/echo/commit/69a0de84158fd7cad326599d145c2248bcc15a69"><code>69a0de8</code></a> Mark unmarshallable yaml struct tags as ignored (<a href="https://redirect.github.com/labstack/echo/issues/2536">#2536</a>)</li> <li><a href="https://github.com/labstack/echo/commit/98a523756d875bc13475bcb6237f09e771cbe321"><code>98a5237</code></a> Changelog for v4.11.2 (<a href="https://redirect.github.com/labstack/echo/issues/2529">#2529</a>)</li> <li><a href="https://github.com/labstack/echo/commit/89ae0e5f2ca6d01665255fd2e479ba98ab5ff4c8"><code>89ae0e5</code></a> Bump dependancies (<a href="https://redirect.github.com/labstack/echo/issues/2522">#2522</a>)</li> <li><a href="https://github.com/labstack/echo/commit/5780908c7cb110a8c4d56a62e32dc5cbc030a5ab"><code>5780908</code></a> Fix CVE-2023-39325 / CVE-2023-44487 (<a href="https://redirect.github.com/labstack/echo/issues/2527">#2527</a>)</li> <li><a href="https://github.com/labstack/echo/commit/4bc3e475e3137b6402933eec5e6fde641e0d2320"><code>4bc3e47</code></a> cors middleware: allow sending <code>Access-Control-Max-Age: 0</code> value with config....</li> <li><a href="https://github.com/labstack/echo/commit/3950c444b726c1de9131d4dee4c9ae708768f26c"><code>3950c44</code></a> fix some typos (<a href="https://redirect.github.com/labstack/echo/issues/2511">#2511</a>)</li> <li>Additional commits viewable in <a href="https://github.com/labstack/echo/compare/v4.11.1...v4.11.3">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Currently the 'fail' sub-test completes by reaching a deadline, which is set to 120 seconds. There is little point waiting 120s when the success path completes in ms. Sets the context provided to timeout after 5 seconds instead of 120s.
MichaelHoepler
added
the
th/documentation
|
@wdbaruni Those are a lot of changes we did on the structure and some content of the documentation. If you have questions regarding the changes, please let me know. |
|
@MichaelHoepler there are still two comments from my previous review outstanding. |
|
@simonwo Removed all the unnecessary files from the branch. |
simonwo
approved these changes
Feb 1, 2024
links updating
aronchick
added a commit
that referenced
this pull request
Feb 1, 2024
Rebased doc branch. Should be able to merge now. --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: n.garanovich <[email protected]> Co-authored-by: Ross Jones <[email protected]> Co-authored-by: frrist <[email protected]> Co-authored-by: Simon Worthington <[email protected]> Co-authored-by: Simon Worthington <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Forrest <[email protected]> Co-authored-by: Al Norman <[email protected]> Co-authored-by: David Aronchick <[email protected]> Co-authored-by: axel <[email protected]> Co-authored-by: AlekseyKorzik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased doc branch. Should be able to merge now.