adding testing bacalhau running script #3157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also clean up some tech debt around labels – make it part of the node setup proper, which paves the way for labels to be regenerated on every publish in the future.
…-but-dont-have-access-to-the-test-bucket
This commit allows the CLI to show a node ranking error message when
nodes don't have the available engine installed.
We do this by removing the FindNodes method previously used for node
discovery. This used to pre-filter the returned nodes to remove any
that did not support the engine, but this meant that they wouldn't
even appear to the ranking system and wouldn't appear on the CLI
either. This was only here as a performance optimisation, but it's
premature (ranking will still take milliseconds even with a 10,000
node cluster).
Now, we just list all nodes and filter them using the engine ranking
strategy instead. In fact, this strategy has been present for months
and is even enabled, it just never did anything because it was never
passed any nodes to filter out. It works just fine, and provides users
with a helpful error messgae, as below:
% bacalhau docker run ubuntu date
Using default tag: latest. Please specify a tag/digest for better reproducibility.
Job successfully submitted. Job ID: 270ad777-1279-48f1-bc51-c7aa900a90e8
Checking job status... (Enter Ctrl+C to exit at any time, your job will continue running):
Communicating with the network ................ done ✅ 0.0s
Creating job for submission ................ err ❌ 0.5s
Error submitting job: not enough nodes to run job. requested: 1, available: 0.
Node QmT5mqWF: does not support docker, only wasm
…n-s3-credentials-are-valid-but-dont-have-access-to-the-test-bucket
…3151-fix-tests-when-s3-credentials-are-valid-but-dont-have-access-to-the-test-bucket
…sts-when-s3-credentials-are-valid-but-dont-have-access-to-the-test-bucket
…-tests-when-s3-credentials-are-valid-but-dont-have-access-to-the-test-bucket
…ave-access-to-the-test-bucket' into bacalhau_server_running_tester
The issue is that we are slow at approving PRs, i started using stacked branches so each PR was small, but worked when done in order - https://andrewlock.net/working-with-stacked-branches-in-git-is-easier-with-update-refs/ - this minimizes pain, but requires we do things in order (which is not clear to me how to signal). This one IS different, but only very small so it looks the same. |
simonwo
reviewed
Jan 4, 2024
simonwo
approved these changes
Jan 5, 2024
auto-merge was automatically disabled
January 5, 2024 16:21
Rebase failed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.