fix: allow compute timeouts to be configured #2931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonwo
approved these changes
Oct 18, 2023
Comment on lines
+30
to
+35
| { | ||
| FlagName: "default-job-execution-timeout", | ||
| ConfigPath: types.NodeComputeJobTimeoutsJobExecutionTimeoutClientIDBypassList, | ||
| DefaultValue: Default.Node.Compute.JobTimeouts.DefaultJobExecutionTimeout, | ||
| Description: `default value for the execution timeout this compute node will assign to jobs with no timeout requirement defined.`, | ||
| }, |
There was a problem hiding this comment.
FYI this value should also be used by the requester node which will apply a default timeout if the timeout is below the minimum timeout. Same with min timeout above. So we will need to find a way to share these flags sooner rather than later.
There was a problem hiding this comment.
Follow on for this here: #2940
|
You will need to inform the LabDAO users that you have changed the name of the flag – please make a note to do this when you make the release. |
frrist
force-pushed
the
frrist/fix/2870
branch
from
1d00c9b to
429239d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
max-timeouthas been renamed tomax-job-execution-timeoutto be more specific to its purpose. (docs change here: https://github.com/bacalhau-project/docs.bacalhau.org/pull/283)