ensure publisher accepts non-name address

pkg/publisher/local/publisher.go

@@ -28,7 +28,7 @@ type Publisher struct {
 func NewLocalPublisher(ctx context.Context, directory string, host string, port int) *Publisher {
 	p := &Publisher{
 		baseDirectory: directory,
-		host:          resolveAddress(ctx, host),
+		host:          ResolveAddress(ctx, host),
 		port:          port,
 		urlPrefix:     fmt.Sprintf("http://%s:%d", host, port),
 	}
@@ -93,20 +93,14 @@ func (p *Publisher) PublishResult(
 
 var _ publisher.Publisher = (*Publisher)(nil)
 
-func resolveAddress(ctx context.Context, address string) string {
+func ResolveAddress(ctx context.Context, address string) string {
 	addressType, ok := network.AddressTypeFromString(address)
-	if !ok {
-		log.Ctx(ctx).Debug().Stringer("AddressType", addressType).Msgf("unable to find address type: %s, binding to 0.0.0.0", address)
-		return "0.0.0.0"
-	}
-
-	// If we were provided with an address type and not an address, so we should look up
-	// an address from the type.
-	addrs, err := network.GetNetworkAddress(addressType, network.AllAddresses)
-	if err == nil && len(addrs) > 0 {
-		return addrs[0]
+	if ok {
+		addrs, err := network.GetNetworkAddress(addressType, network.AllAddresses)
+		if err == nil && len(addrs) > 0 {
+			return addrs[0]
+		}
 	}
 
-	log.Ctx(ctx).Error().Err(err).Stringer("AddressType", addressType).Msgf("unable to find address for type, using 127.0.0.1")
-	return "127.0.0.1"
+	return address
 }

pkg/publisher/local/publisher_test.go

@@ -34,6 +34,14 @@ func (s *PublisherTestSuite) SetupTest() {
 	s.pub = local.NewLocalPublisher(s.ctx, s.baseDir, defaultHost, defaultPort)
 }
 
+func (s *PublisherTestSuite) TestAddressResolving() {
+	ctx := context.Background()
+
+	s.Require().Equal("127.0.0.1", local.ResolveAddress(ctx, "127.0.0.1"), "address did not resolve to itself")
+	s.Require().Equal("192.168.1.100", local.ResolveAddress(ctx, "192.168.1.100"), "address did not resolve to itself")
+	s.Require().Equal("127.0.0.1", local.ResolveAddress(ctx, "local"))
+}
+
 func (s *PublisherTestSuite) TestPublishFolder() {
 	source := s.T().TempDir()