fix: check error when getting job history (#4512)

- related to #4510 --------- Co-authored-by: frrist <[email protected]> Co-authored-by: Walid Baruni <[email protected]>
bacalhau-project · Sep 25, 2024 · d004042 · d004042
1 parent d5e5f57
commit d004042
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/pkg/jobstore/boltdb/store.go b/pkg/jobstore/boltdb/store.go
@@ -662,6 +662,12 @@ func (b *BoltJobStore) getJobHistory(tx *bolt.Tx, jobID string, query jobstore.J
 
 	bkt, err := NewBucketPath(BucketJobs, jobID, BucketJobHistory).Get(tx, false)
 	if err != nil {
+		// If the bucket doesn't exist, then we return an empty response to maintain compatibility
+		// with < v1.5.0 versions as the history bucket name was renamed in v1.5.0 without migration
+		// as migration is not worth the complexity
+		if errors.Is(err, bolt.ErrBucketNotFound) {
+			return &jobstore.JobHistoryQueryResponse{}, nil
+		}
 		return nil, NewBoltDbError(err)
 	}
 

diff --git a/pkg/publicapi/endpoint/orchestrator/job.go b/pkg/publicapi/endpoint/orchestrator/job.go
@@ -97,10 +97,10 @@ func (e *Endpoint) getJob(c echo.Context) error { //nolint: gocyclo
 				continue
 			}
 			jobHistoryQueryResponse, err := e.store.GetJobHistory(ctx, jobID, jobstore.JobHistoryQuery{})
-			history := jobHistoryQueryResponse.JobHistory
 			if err != nil {
 				return err
 			}
+			history := jobHistoryQueryResponse.JobHistory
 			response.History = &apimodels.ListJobHistoryResponse{
 				Items: make([]*models.JobHistory, len(history)),
 			}